ISSUE #30 - #32
Open
JonSun42 wants to merge 6 commits into
Open
Conversation
Modified the procedure of adding air spaces in the mesohyll of `NeedleAnatomy` Air spaces are now placed (still post-fill) as rhombi in mid-wall positions between adjacent mesohyll cells: `Cell` has new attribute `protect_topology: bool = False` if `True` wall flattening is inhibited. This is necessary to prevent rhombi's secondary axis to collapse. Resulting new vertices are promoted to junction nodes in `CellGenerator` `special_tissue.py` has new method `seat_air_spaces` used in `Organ` and `NeedleAnatomy` `needle_mesohpyll_airspaces.py` has been added as a *diagnostic* example (intentionally not put as a test to prevent computational effort for PRs) Golden test has been modified in needle_default/needle_feature -> # air spaces All other tests passed ✓
Rhombus side are now maintained as "crooked" wall without adding junctions.
- cut symplastic connections from air space nodes to adjacent mesphyll cells - connected air space nodes through new pathway "air_link" through a Y scheme (avoiding direct crossing the mesophyll cytoplasm)
…terfacial transport between "wet" wall nodes and "dry" air spaces
…hpyll air space related searches
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the procedure of adding air spaces in the mesohyll of
NeedleAnatomyAir spaces are now placed (still post-fill) as rhombi in mid-wall positions between adjacent mesohyll cells:
Cellhas new attributeprotect_topology: bool = FalseifTruewall flattening is inhibited. This is necessary to prevent rhombi's secondary axis to collapse. Resulting new vertices are promoted to junction nodes inCellGeneratorspecial_tissue.pyhas new methodseat_air_spacesused inOrganandNeedleAnatomyneedle_mesohpyll_airspaces.pyhas been added as a diagnostic example (intentionally not put as a test to prevent computational effort for PRs)Golden test has been modified in needle_default/needle_feature -> # air spaces All other tests passed ✓