Skip to content

Fix README.md#53

Open
kimdiallo wants to merge 1 commit into
openairplay:masterfrom
kimdiallo:patch-1
Open

Fix README.md#53
kimdiallo wants to merge 1 commit into
openairplay:masterfrom
kimdiallo:patch-1

Conversation

@kimdiallo

Copy link
Copy Markdown

Source the prepared virtualenv in the Debian- and corrects the path to requirements.txt in all install instructions.

Source the prepared virtualenv  in the Debian-  and corrects the path to requirements.txt in all  install instructions.
@Neustradamus

Copy link
Copy Markdown
Contributor

@systemcrash: What do you think?

@systemcrash

Copy link
Copy Markdown
Member

Can anyone who uses virtualenv confirm that this is the case? I never got it to install/work. So I use directly.

@systemcrash systemcrash force-pushed the master branch 9 times, most recently from 52f827e to 017e620 Compare January 4, 2022 23:29
@m3brown

m3brown commented Mar 13, 2022

Copy link
Copy Markdown
Contributor

I do not believe the changes proposed in this PR will work, and the existing instructions are fine.

The procedure suggests the pip install commands are run from the root of the repository (which the README calls airplay2-receiver/). The requirements.txt is in the root of the repository, so there is no need for a ../ unless you're running the pip command from a subdirectory (such as docker/, or ap2/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants