Begin work to support DiskImageKit in tart - #1303
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd363baad6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fd363ba to
2c88d63
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c88d63290
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2c88d63 to
c4a48df
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4a48df1f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dd5be53 to
3305159
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3305159cd4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3305159 to
a5e6a62
Compare
This is first of several changes to add support for the new DiskImageKit ASIF layers to tart VM images. This change is focused on laying down the OCI media type for ASIF layers, the DiskLayerCache structure, as well as the VMDirectory structure for supporting layers. Add DiskImageStack type to model VM image using DiskImage APIs.
a5e6a62 to
7641f87
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7641f87b4c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let baseURL: URL | ||
|
|
||
| init() throws { | ||
| try self.init(baseURL: Config().tartCacheDir.appendingPathComponent("OCIs/content", isDirectory: true)) |
There was a problem hiding this comment.
When using a valid remote whose host is content, namespace is sha256, and tag is a 64-character hex string (for example, content/sha256:<hex>), VMStorageOCI.appendingRemoteName maps the VM to the same path this cache uses for that digest. A pull can therefore replace a cached disk file with a VM directory, while subsequent cache lookups can fail when they attempt to hash that directory. Place the content cache outside OCIs, or under a path component that cannot be a valid registry host.
Useful? React with 👍 / 👎.
1 participant
This is first of a couple of PRs to add support for the new
DiskImageKit ASIF layers to tart VM images.
https://developer.apple.com/documentation/diskimagekit
This change is focused on laying down the OCI media type for
ASIF layers, the DiskLayerCache structure, DiskImageStack type,
as well as the VMDirectory structure for supporting layers.
Since this is a larger feature I am doing this in smaller PRs to help
with review.
Issue: #1269