fix(voice): decode provider PCM16 as little-endian - #4884
Closed
harshitethic wants to merge 2 commits into
Closed
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decode provider PCM16 bytes with an explicit little-endian dtype instead of the host-native
np.int16interpretation, then normalize to nativeint16before returning audio to callers.This fixes the big-endian-host corruption described in #4816 while preserving the existing
np.int16/np.float32output shapes and odd-byte padding behavior.Tests
Adds focused coverage using
b"\x01\x02\x03\x04", which must decode to samples[513, 1027]for both integer and float output paths.Closes #4816
AI assistance disclosure: AI assistance was used to inspect the issue, prepare the focused implementation and regression tests, and review the resulting diff.