fix: route verification changes and require confirmed docs-only pushes - #4880
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
sylvesterkaczmarek
left a comment
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
I went through the failure semantics here as well as the expanded path routing. The asymmetry in unknown_changes() is the important part: uncertainty forces verification to run, while the same uncertainty cannot authorize a docs deployment. That is the safer default in both directions.
Fetching both endpoint commits before diffing also closes the shallow-checkout and force-push cases, and using --no-renames -z is a good detail: a code-to-docs rename still exposes the removed code path to the verifier, while unusual path names cannot corrupt the file list. The new tests exercise those cases directly, including failed diffs, missing SHAs, empty diffs and mixed pushes. I also checked the docs/scripts/ overlap: treating those files as both documentation and code inputs makes sense because generator changes need verification even when the resulting push remains docs-only.
This is a substantial improvement over having separate ad-hoc change detection in the workflow. I don’t see another routing gap in the current change set.
83d33eb to
bd13700
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96b96234c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@sylvesterkaczmarek Could you please refrain from posting review comments when you do not have any specific issues to raise? We would like to keep PR discussions focused on actionable feedback and direction from the maintainers. |
2 participants
This pull request fixes skipped CI checks when verification scripts, workflow controls, or typecheck configuration change. Documentation deployment now uses the shared change detector, fetches missing event commits, and requires a successful, nonempty docs-only diff. Mixed changes, failed comparisons, and code-to-docs renames cannot authorize deployment.