Skip to content

fix(core/voice): honor OpenAI provider options over default clients - #4530

Merged
seratch merged 2 commits into
openai:mainfrom
green3sf:fix/provider-options-override-default-client
Aug 20, 2026
Merged

fix(core/voice): honor OpenAI provider options over default clients#4530
seratch merged 2 commits into
openai:mainfrom
green3sf:fix/provider-options-override-default-client

Conversation

@green3sf

@green3sf green3sf commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

This pull request fixes both OpenAIProvider and OpenAIVoiceModelProvider silently ignoring provider-specific client options when a global default OpenAI client is configured.

For OpenAIProvider, explicit api_key, base_url, websocket_base_url, organization, or project values now select a provider-specific client. For OpenAIVoiceModelProvider, explicit api_key, base_url, organization, or project values do the same.

Explicit empty values are preserved instead of falling through to global credentials or endpoint environment variables. Providers with all construction options omitted continue to reuse the exact global default client, and the existing explicit-client acceptance and conflict behavior remains unchanged.

Test plan

  • Ran the focused provider, voice-provider, and configuration suites: 56 passed.
  • Confirmed the 8 new voice regression cases fail against the unmodified merge-base source and pass with this patch.
  • Ran .agents/skills/code-change-verification/scripts/run.sh; formatting, linting, type checking, and the full test suite all passed.

Issue number

None.

Checks

  • I've added new tests, if relevant
  • I've run .agents/skills/code-change-verification/scripts/run.sh
  • I've confirmed all verification steps pass
  • If using Codex, I've run /review before submitting this PR

@green3sf green3sf changed the title fix: honor OpenAIProvider client options over the default client fix: honor OpenAI provider options over default clients Aug 20, 2026
@seratch seratch added this to the 0.22.x milestone Aug 20, 2026
@seratch seratch changed the title fix: honor OpenAI provider options over default clients fix(core/voice): honor OpenAI provider options over default clients Aug 20, 2026
@seratch
seratch enabled auto-merge (squash) August 20, 2026 02:49
@seratch
seratch merged commit bfb981d into openai:main Aug 20, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants