Skip to content

fix(examples): run Prisma setup on Windows - #1781

Open
sylvesterkaczmarek wants to merge 1 commit into
openai:mainfrom
sylvesterkaczmarek:fix/windows-prisma-memory-example
Open

fix(examples): run Prisma setup on Windows#1781
sylvesterkaczmarek wants to merge 1 commit into
openai:mainfrom
sylvesterkaczmarek:fix/windows-prisma-memory-example

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown
Contributor

Summary

Fix the Prisma memory example on Windows under current Node versions.

examples/memory/start-prisma.ts selects pnpm.cmd on Windows and passes it directly to spawnSync. Node 20.12.2 and newer reject direct .cmd/.bat spawning, so pnpm -F memory start:prisma can fail before Prisma runs.

This is a remaining occurrence of the Windows shim pattern reported in #1775. The open #1776 fix covers the verification runner and scripts/prettier-changed.mjs, but does not cover the Prisma memory example.

Changes

  • route Prisma commands through ComSpec / cmd.exe on Windows
  • keep direct pnpm spawning on non-Windows platforms
  • preserve the existing Prisma arguments, working directory, environment, exit-code, and signal handling
  • add focused regression coverage for Windows, non-Windows, and custom ComSpec invocation

Test plan

  • added focused invocation tests under the workspace Vitest project
  • verified the branch is one commit ahead of current upstream main
  • full Windows runtime execution is left to CI/reviewer validation

Issue number

No separate issue. Found while checking the remaining Windows .cmd spawn sites after #1775.

Checks

  • Added focused regression coverage
  • No published package code changed, so no changeset is required

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T10:01:37.426063Z 8da983d PR opened
🔒 Security Review Completed 2026-09-01T10:04:12.336161Z 8da983d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@changeset-bot

changeset-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8da983d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant