You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix the Prisma memory example on Windows under current Node versions.
examples/memory/start-prisma.ts selects pnpm.cmd on Windows and passes it directly to spawnSync. Node 20.12.2 and newer reject direct .cmd/.bat spawning, so pnpm -F memory start:prisma can fail before Prisma runs.
This is a remaining occurrence of the Windows shim pattern reported in #1775. The open #1776 fix covers the verification runner and scripts/prettier-changed.mjs, but does not cover the Prisma memory example.
Changes
route Prisma commands through ComSpec / cmd.exe on Windows
keep direct pnpm spawning on non-Windows platforms
preserve the existing Prisma arguments, working directory, environment, exit-code, and signal handling
add focused regression coverage for Windows, non-Windows, and custom ComSpec invocation
Test plan
added focused invocation tests under the workspace Vitest project
verified the branch is one commit ahead of current upstream main
full Windows runtime execution is left to CI/reviewer validation
Issue number
No separate issue. Found while checking the remaining Windows .cmd spawn sites after #1775.
Checks
Added focused regression coverage
No published package code changed, so no changeset is required
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Prisma memory example on Windows under current Node versions.
examples/memory/start-prisma.tsselectspnpm.cmdon Windows and passes it directly tospawnSync. Node 20.12.2 and newer reject direct.cmd/.batspawning, sopnpm -F memory start:prismacan fail before Prisma runs.This is a remaining occurrence of the Windows shim pattern reported in #1775. The open #1776 fix covers the verification runner and
scripts/prettier-changed.mjs, but does not cover the Prisma memory example.Changes
ComSpec/cmd.exeon Windowspnpmspawning on non-Windows platformsComSpecinvocationTest plan
mainIssue number
No separate issue. Found while checking the remaining Windows
.cmdspawn sites after #1775.Checks