Reduce redundant filesystem syscalls#31514
Open
charliemarsh-oai wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Several paths performed redundant filesystem syscalls or split a check from the operation it guarded. Besides extra I/O, reopening the temporary pathname creates a substitution race, and preflight existence checks can go stale before the subsequent operation. Performing the operation directly preserves behavior while avoiding those windows.
The affected crate tests pass, along with scoped Clippy and formatting. The full TUI suite continues to have the two known Guardian feature-flag persistence failures present on main; the focused daemon socket tests pass.