Fall back to HTTP when Apple Git is unavailable#31496
Open
fc-oai wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/usr/bin/gitshim as unavailable whenxcode-select -preports that developer tools are absentRoot cause
Curated plugin startup sync invokes
git ls-remotebefore its HTTP fallback. On a clean Mac,gitresolves to Apple’s/usr/bin/gitshim, and executing the shim opens the Xcode Command Line Tools installer before the process can fail and reach HTTP.This change resolves Git through
PATHwithout executing it. If the selected binary is Apple’s shim and developer tools are unavailable, startup sync marks the Git transport unavailable and enters the existing HTTP fallback immediately.Eager Git audit
I also audited production Git process spawns in
codex-rs..gitentry./diffpaths are explicitly user-invoked.Validation
just test -p codex-core-plugins— 313 passedcargo fmt -p codex-core-plugins -- --checkgit diff --checkjust bazel-lock-update— succeeded with no lockfile deltajust fix -p codex-core-pluginswas attempted, but the local shared Rust target exhausted disk before completion; it emitted no source diagnostic