[TPP-502] fix(imagegen): avoid duplicate markdown image links#31485
[TPP-502] fix(imagegen): avoid duplicate markdown image links#31485kunyao-liu wants to merge 2 commits into
Conversation
kunyao-liu
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a7084857d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Root cause
The shared image-generation output hint exposed the saved image path without explaining that the client had already rendered the generated-image item. The model could then repeat the same image as a Markdown image or file link.
Validation
just test -p codex-image-generation-extensiongit diff --checkcargo fmt --manifest-path codex-rs/Cargo.toml --allAttempted
just test -p codex-core handle_output_item_done_records_image_save_history_message; local linking of the largecodex-coretest binary failed before the test ran.