Migrate plugin commands into skills#31482
Conversation
charlesgong-openai
force-pushed
the
dev/charlesgong/plugin-command-skills
branch
2 times, most recently
from
4a8aa23 to
aaa6042
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aaa60428ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| semver = { workspace = true } | ||
| serde = { workspace = true, features = ["derive"] } | ||
| serde_json = { workspace = true } | ||
| serde_yaml = { workspace = true } |
There was a problem hiding this comment.
Adding serde_yaml changes the Rust dependency graph for codex-core-plugins, but this commit updates only Cargo.toml/Cargo.lock; without the corresponding MODULE.bazel.lock refresh, Bazel-based builds and the lockfile-drift check will still resolve the old crate graph. Run just bazel-lock-update from the repo root and include the resulting MODULE.bazel.lock change with this dependency addition.
AGENTS.md reference: AGENTS.md:L37-L39
Useful? React with 👍 / 👎.
| let migrated_command_skills = migrated_command_skills_root(plugin_root); | ||
| if migrated_command_skills.is_dir() { | ||
| paths.push(migrated_command_skills); |
There was a problem hiding this comment.
If an installed plugin already contains .codex-plugin/migrated-command-skills, this unconditional append loads those skills even when they were never generated from commands/ and even when the manifest/fallback restricts skills to a different path. Because the store copies the source tree before calling migration, a package can pre-populate this internal directory and get undeclared skills exposed; only load a migration output that was freshly generated or clear/own that directory during install.
Useful? React with 👍 / 👎.
charlesgong-openai
force-pushed
the
dev/charlesgong/plugin-command-skills
branch
from
aaa6042 to
97f3ff7
Compare
1 participant
Summary
codex-external-agent-migrationintocodex-core-plugins, avoiding a dependency cycle when plugin installation uses the conversioncommands/during atomic install staging and expose generated skills alongside explicit manifest skill pathsValidation
just test -p codex-external-agent-migration(19 passed)just test -p codex-core-plugins(new migration coverage passed; the only failure in the full run was an existing HOME-sensitive cache test, which passed when rerun with a clean HOME)just test -p codex-app-server(affected external-agent and plugin tests passed; unrelated failures/timeouts were caused by nestedsandbox-execrestrictions, missing auxiliary test binaries, and a HOME-sensitive skill watcher)just fix -p codex-core-plugins -p codex-external-agent-migration -p codex-app-servercargo fmt -- --config imports_granularity=Item(just fmtwas attempted but its parallel formatter helper daemon terminated)