Add plugin install suggestion outcome analytics#31432
Open
adaley-openai wants to merge 2 commits into
Open
Conversation
adaley-openai
force-pushed
the
dev/adaley/plugin-suggestion-outcome-event
branch
from
1e0aae6 to
0d107ea
Compare
adaley-openai
changed the title
mzeng-openai
reviewed
Jul 7, 2026
| pub(crate) remote_plugin_id: Option<String>, | ||
| pub(crate) connector_ids: Vec<String>, | ||
| pub(crate) selected: bool, | ||
| pub(crate) completed: bool, |
Collaborator
There was a problem hiding this comment.
could we land the matching server schema before adding tools[].completed here? the current server request model has no nested completed, so Pydantic will drop this field and partial outcomes will still collapse to the top-level bit.
mzeng-openai
reviewed
Jul 7, 2026
| completed: bool, | ||
| ) { | ||
| let completed_tag = if completed { "true" } else { "false" }; | ||
| self.counter( |
Collaborator
There was a problem hiding this comment.
could we keep this counter until the stacked emitter lands? at this head the new analytics method has no caller, so removing the existing outcome metric creates a coverage gap if this slice ships before #31484.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack
Validation