Refactor the cmd router away - #20253
Merged
hennevogel merged 1 commit intoSep 4, 2026
Merged
Conversation
github-actions
Bot
added
Documentation 📖
Member
Author
|
For the record: Still a bad idea to invent an API route to workaround timing issues in a smoke test... |
krauselukas
reviewed
Sep 3, 2026
hennevogel
force-pushed
the
refactoring/distribution-refresh
branch
4 times, most recently
from
September 3, 2026 11:03
3c2db98 to
1a1b3e7
Compare
krauselukas
approved these changes
Sep 3, 2026
We already have a router, no need to invent another one via parameters... Also: - Only render an error if FetchRemoteDistributionsJob has gone wrong - Rspec can do POST requests, no need for Net::HTTP
hennevogel
force-pushed
the
refactoring/distribution-refresh
branch
from
September 3, 2026 15:01
997dfa4 to
3ba8e43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have a router, no need to invent another one via parameters...
Also: