Repository navigation
Conversation
Signed-off-by: Isaac S. <107325320+isaacsa2@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native test jobs use --all-features, which enables device_lost_panic. pipeline_creation_errors deliberately injects ERROR_DEVICE_LOST and then expects a returned DeviceError::Lost, although this feature deliberately panics instead. That assertion fails on the unchanged openomsi/v29 base too.
Give device loss its own test: check the returned error normally, and expect the documented debug panic when the feature is enabled. Other pipeline errors remain checked by the existing test. Production error handling is unchanged.
Validation: reproduced the base failure with vulkan,device_lost_panic; both pipeline tests pass with vulkan alone, with vulkan,device_lost_panic, and with --all-features. They also pass with the GL fix from #1 applied. Formatting and dependency advisories are separate maintenance changes.