Repository navigation
Conversation
Signed-off-by: Isaac S. <107325320+isaacsa2@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The limited Miri job filters for WriteOnly tests in wgpu, but those tests live in wgpu-types. On the current nightly it fails while compiling unrelated wgpu-core Send/Sync code; after that error is avoided, it can report success with zero selected tests.
Run the owning package with std and serde so its unit tests compile, and reject an empty passing-test count. The shell retains pipefail, so tee cannot hide a failed Miri run. No compiler recursion limit or check suppression is added.
Validation: the corrected command executed 25 WriteOnly tests, all passing, with nightly-2026-10-26 and RUSTFLAGS=-Dwarnings. The count guard also passed. This is independent of #1; dependency advisories, Vulkan test semantics and pre-existing formatting remain separate changes.