WsStreamingServer rece fix - #10
Merged
Merged
Conversation
…) call. server::on_connection_disconnected mutates _clients on the asio io thread while server::close() clears the same unguarded std::list on the main thread (WsStreamingServer::onStopServer calls close() before stopping/joining the io thread)
NikolaiShipilov
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops boost::asio::io_context processing thread before _server.close() call.
server::on_connection_disconnected mutates _clients on the asio io thread while server::close() clears the same unguarded std::list on the main thread (WsStreamingServer::onStopServer calls close() before stopping/joining the io thread).