fix: stop deleting user text that looks like a skill mention - #29051
Open
Classic298 wants to merge 1 commit into
Open
fix: stop deleting user text that looks like a skill mention#29051Classic298 wants to merge 1 commit into
Classic298 wants to merge 1 commit into
Conversation
Any `<$...>` run in a chat message was treated as an inline skill mention and removed before the request reached the model, so text like `<$(=MonthStart($(vMaxMonthEndINC)))"}, [Registration day] >` silently vanished mid-message and the model only saw the part before it. The mention regexes accepted any character except `|` and `>` as the skill id, so they matched far more than real mentions. Skill ids are already validated as `[a-z0-9_-]+` when a skill is created, so both regexes now require that charset. Ordinary text passes through untouched while `<$id>`, `<$id|Label>` and `</id|Label>` still resolve and strip as before. Verified against the reported message (now preserved verbatim) and the three mention forms.
12 tasks
Classic298
force-pushed
the
claude/commit-review-workflow-lx6kcv
branch
from
August 26, 2026 09:32
c507b35 to
1276993
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any
<$...>run in a chat message was treated as an inline skill mention and removed before the request reached the model, so text like<$(=MonthStart($(vMaxMonthEndINC)))"}, [Registration day] >silently vanished mid-message and the model only saw the part before it.The mention regexes accepted any character except
|and>as the skill id, so they matched far more than real mentions. Skill ids are already validated as[a-z0-9_-]+when a skill is created, so both regexes now require that charset. Ordinary text passes through untouched while<$id>,<$id|Label>and</id|Label>still resolve and strip as before.Fixes: #29041
Verified against the reported message (now preserved verbatim) and the three mention forms.
Contributor License Agreement
Note
Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.