bluetooth: hogp: add build system registration#50
Open
chengkai15 wants to merge 1 commit into
Open
Conversation
chengkai15
force-pushed
the
feature/dev-hogp
branch
from
e5b6f76 to
67b61e9
Compare
bug: v/89553 Add HOGP Device/Host compilation entries in both CMakeLists.default.txt and Makefile.default so that CONFIG_BT_HOGP_DEVICE and CONFIG_BT_HOGP_HOST actually compile hogp_device.c / hogp_host.c into the final binary. Signed-off-by: Kai Cheng <chengkai@xiaomi.com>
chengkai15
force-pushed
the
feature/dev-hogp
branch
from
67b61e9 to
ad5e6b4
Compare
huangyulong3
approved these changes
May 8, 2026
gzh-terry
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add HOGP Device/Host compilation entries in both
CMakeLists.default.txtand
Makefile.defaultso thatCONFIG_BT_HOGP_DEVICEandCONFIG_BT_HOGP_HOSTactually compile
hogp_device.c/hogp_host.cinto the final binary.Why
external/zblue/zblue/subsys/bluetooth/services/hogp/{hogp_device,hogp_host}.care introduced by the inner zblue feature branch (see external_zblue#226), but
the outer zblue wrapper build system (
Makefile.default+CMakeLists.default.txt)did not register these source files, so turning on
CONFIG_BT_HOGP_DEVICE=yand
CONFIG_BT_HOGP_HOST=yhad no effect — HOGP object files never participatedin the link.
This PR adds the CSRCS entries in both build systems. After merge,
CONFIG_BT_HOGP_DEVICE=y/CONFIG_BT_HOGP_HOST=ycorrectly include theHOGP implementation into
libapps.a.Dependencies
How tested
Local build on
vendor/openvela/boards/vela/configs/goldfish-armeabi-v7a-apwith
CONFIG_BT_HOGP_DEVICE=y+CONFIG_BT_HOGP_HOST=y:nm nuttx | grep bt_hogp_shows allbt_hogp_device_*/bt_hogp_host_*T symbols.ofiles present inlibapps.abug: v/89553