Skip to content

[DEVEX-907] Make setup-node conditional in action-pre-commit to preserve baked pre-commit cache #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
HammerZhaoTuro wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[DEVEX-907] Make setup-node conditional in action-pre-commit to preserve baked pre-commit cache #198

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b2270a
fix: make setup-node conditional to preserve baked pre-commit cache
HammerZhaoTuro Jul 15, 2026
d13819f
test: point commitlint sub-action to feature branch
HammerZhaoTuro Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,19 @@ runs:
# install python.
PYTHON_BIN=$(command -v python || true)
echo "PYTHON_BIN=$PYTHON_BIN" >> $GITHUB_ENV

# Finding node
# Skip setup-node when the runner image already has node, so
# pre-commit's baked hook environments (keyed on the system node
# path) are not invalidated by a different node landing on PATH.
NODE_BIN=$(command -v node || true)
echo "NODE_BIN=$NODE_BIN" >> $GITHUB_ENV
- name: Setup python
# Only run this if we don't already have a pre-commit on the PATH
if: env.PYTHON_BIN == null && env.PRE_COMMIT_BIN == null && steps.pre-commit-config.outputs.exists != 'false'
uses: actions/setup-python@v6
- name: Determine node version
if: env.NODE_BIN == ''
id: node-version
shell: bash
run: |
Expand All @@ -88,13 +96,14 @@ runs:
echo "version=24" >> $GITHUB_OUTPUT
fi
- name: Setup node
if: env.NODE_BIN == ''
uses: actions/setup-node@v6
with:
node-version: ${{ steps.node-version.outputs.version }}
- name: Commitlint
# This version needs to be sync'd with the repo HEAD if a major version is cut
if: inputs.disable-commitlint != 'true'
uses: open-turo/action-pre-commit/commitlint@v3
uses: open-turo/action-pre-commit/commitlint@f/devex-907_make_setup-node_conditional_in_action-pre-commit_to_preserve_baked_pre-c
with:
restore-config: "false"
config-file: ${{ inputs.config-file }}
Expand Down
Loading