Skip to content

Warn on invalid markdown snippet markers#1576

Open
ahfoysal wants to merge 1 commit into
open-telemetry:mainfrom
ahfoysal:warn-invalid-markdown-snippets
Open

Warn on invalid markdown snippet markers#1576
ahfoysal wants to merge 1 commit into
open-telemetry:mainfrom
ahfoysal:warn-invalid-markdown-snippets

Conversation

@ahfoysal

@ahfoysal ahfoysal commented Jul 7, 2026

Copy link
Copy Markdown

Refs #501

This warns when registry update-markdown sees an HTML comment that looks like a semconv/weaver snippet marker but does not parse as one. It also requires whitespace after semconv and weaver marker keywords so typos like <!-- semconvmetric.foo --> are not treated as valid snippets.

Tests:

  • cargo fmt --all --check
  • cargo test -p weaver_semconv_gen recognizes_invalid_snippet_markers
  • cargo test -p weaver test_registry_update_markdown_warns_on_invalid_snippet_marker

@ahfoysal ahfoysal requested a review from a team as a code owner July 7, 2026 06:17
@linux-foundation-easycla

Copy link
Copy Markdown

CLA Not Signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant