Draft
Consolidate v2 unstable file format warnings and improve diagnostic report styling#1404
Conversation
…der yellow for warnings-only Agent-Logs-Url: https://github.com/open-telemetry/weaver/sessions/0e6c4b41-ee69-49b2-9e94-2465dbd7124c Co-authored-by: lmolkova <2347409+lmolkova@users.noreply.github.com>
… warning Agent-Logs-Url: https://github.com/open-telemetry/weaver/sessions/9bafb46b-252b-49a6-944c-6580b2107a71 Co-authored-by: lmolkova <2347409+lmolkova@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
lmolkova
May 3, 2026 19:33
View session
lmolkova
reviewed
May 3, 2026
lmolkova
reviewed
May 3, 2026
…ethod Agent-Logs-Url: https://github.com/open-telemetry/weaver/sessions/0ba60efd-6243-4848-a0c1-973af77935e4 Co-authored-by: lmolkova <2347409+lmolkova@users.noreply.github.com>
Agent-Logs-Url: https://github.com/open-telemetry/weaver/sessions/0ba60efd-6243-4848-a0c1-973af77935e4 Co-authored-by: lmolkova <2347409+lmolkova@users.noreply.github.com>
Agent-Logs-Url: https://github.com/open-telemetry/weaver/sessions/ded673d2-74bd-4bc3-8a73-d6f56182535c Co-authored-by: lmolkova <2347409+lmolkova@users.noreply.github.com>
lmolkova
approved these changes
May 4, 2026
Member
|
@copilot fix ci errors |
Agent-Logs-Url: https://github.com/open-telemetry/weaver/sessions/2f34b3f4-f07c-4089-ac08-200de21629b5 Co-authored-by: lmolkova <2347409+lmolkova@users.noreply.github.com>
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1404 +/- ##
=====================================
Coverage 82.4% 82.4%
=====================================
Files 120 120
Lines 10092 10108 +16
=====================================
+ Hits 8320 8334 +14
- Misses 1772 1774 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@copilot add changelog entry, keep it super-short, match existing style |
Agent-Logs-Url: https://github.com/open-telemetry/weaver/sessions/5973e656-f5bf-4356-b5fb-2583b724f545 Co-authored-by: lmolkova <2347409+lmolkova@users.noreply.github.com>
Contributor
Author
Member
|
Alternative: use diagnostic template to group the same errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
weaver registry checkon v2 schema emits a separate "File formatdefinition/2is not yet stable" warning for every v2 file, producing noisy output. The "Diagnostic report" header also renders in red even when only warnings are present.Changes
UnstableFileFormatwarnings via a new genericError::consolidate()method (crates/weaver_semconv/src/lib.rs): The error type itself owns the deduplication logic, groupingUnstableFileFormatwarnings byfile_formatvalue and merging their provenances into a single warning listing all affected files, e.g.:crates/weaver_resolver/src/loader.rs) simply callsError::consolidate()without any error-type-specific knowledge.defaults/diagnostic_templates/ansi/errors.txt.j2): Render "Diagnostic report" in yellow when all diagnostics are warnings/advice, red only when errors are present.