Skip to content

ci: add shared security scanning workflow - #105

Merged
johannaojeling merged 2 commits into
open-telemetry:mainfrom
opentelemetrybot:zizmor-rollout/sig-repos-20260807
Aug 8, 2026
Merged

ci: add shared security scanning workflow#105
johannaojeling merged 2 commits into
open-telemetry:mainfrom
opentelemetrybot:zizmor-rollout/sig-repos-20260807

Conversation

@opentelemetrybot

Copy link
Copy Markdown
Contributor

Tracked in open-telemetry/sig-security#293.

Adds zizmor scanning through the OpenTelemetry shared workflow.

The workflow:

  • runs the regular persona on pull requests, pushes to main, and a randomized weekly schedule;
  • uploads results to GitHub code scanning;
  • uses the shared workflow pinned to an immutable commit.

After merge

  1. Confirm the Zizmor workflow succeeds on the merged default-branch commit and its code-scanning analysis has no findings.
  2. Mark the corresponding admin PR ready for review and merge it to require zizmor code scanning.
  3. On the next repository pull request, confirm GitHub reports a required zizmor code-scanning result.

If enforcement unexpectedly blocks a valid change, restore require_zizmor = false in open-telemetry/admin while leaving scanning enabled.

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a repository-level GitHub Actions workflow to run Zizmor via the OpenTelemetry shared reusable workflow and upload SARIF to GitHub code scanning, aligning with the security-scanning rollout tracked in open-telemetry/sig-security#293.

Changes:

  • Introduces a new zizmor workflow triggered on PRs, pushes to main, a weekly schedule, and manual dispatch, calling the shared workflow pinned to an immutable commit.
  • Hardens the existing FOSSA workflow by disabling persisted GitHub credentials in the checkout step.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/zizmor.yml Adds Zizmor scanning via the OpenTelemetry shared reusable workflow with least-privilege permissions.
.github/workflows/fossa.yml Sets persist-credentials: false on checkout to reduce token exposure risk.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/zizmor.yml
@opentelemetrybot
opentelemetrybot marked this pull request as ready for review August 7, 2026 16:23
@opentelemetrybot
opentelemetrybot requested a review from a team as a code owner August 7, 2026 16:23
@johannaojeling
johannaojeling merged commit 96ee1dd into open-telemetry:main Aug 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants