fix(instrumentation-http): set conditionally required error.type attribute - #7061
Open
mwear wants to merge 1 commit into
Open
fix(instrumentation-http): set conditionally required error.type attribute#7061mwear wants to merge 1 commit into
mwear wants to merge 1 commit into
Conversation
mwear
force-pushed
the
http-error-type-7059
branch
from
September 3, 2026 17:32
18e27cc to
f13e573
Compare
Pull request dashboard statusWaiting on reviewers · refreshed 2026-09-07 00:37 UTC Review the latest changes. Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7061 +/- ##
=======================================
Coverage 95.00% 95.00%
=======================================
Files 407 407
Lines 14342 14353 +11
Branches 3289 3290 +1
=======================================
+ Hits 13625 13636 +11
Misses 717 717
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
instrumentation-httpsets a span's status to Error from the response status code but never setserror.typeon that span. Semconv markserror.typeas Conditionally Required "If request has ended with an error", and asks for the status code as a string once a response was received. This PR adds it.This was an issue identified by the semantic conventions conformance repo.
Fixes #7059
Short description of the changes
parseErrorTypeinutils.ts. It returns the status code as a string when the code is an error for that span kind,undefinedotherwise.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: