chore: add shared security scanning workflow - #1028
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1028 +/- ##
=======================================
Coverage 17.59% 17.59%
=======================================
Files 24 24
Lines 722 722
=======================================
Hits 127 127
Misses 595 595
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR introduces a new GitHub Actions workflow to run Zizmor via the OpenTelemetry shared workflow and makes small hardening/cleanup updates across existing CI workflows (disabling persisted checkout credentials and simplifying some cache key hashing).
Changes:
- Add a new
.github/workflows/zizmor.ymlworkflow that runs on PRs, pushes tomain, and a weekly schedule, uploading results to code scanning via the shared reusable workflow. - Update multiple workflows to set
actions/checkoutpersist-credentials: false. - Simplify
hashFiles(...)usage in some cache keys.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/zizmor.yml |
Adds Zizmor scanning using the OpenTelemetry shared reusable workflow pinned to an immutable commit. |
.github/workflows/w3c_interop.yml |
Hardens checkout credentials and tweaks cache key hashing (also reveals an invalid matrix.* reference in cache key usage). |
.github/workflows/fossa.yml |
Hardens checkout by disabling persisted credentials. |
.github/workflows/erlang.yml |
Hardens checkout credentials and simplifies cache key hashing. |
.github/workflows/elixir.yml |
Hardens checkout by disabling persisted credentials across multiple jobs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
08c54e1 to
dd45f8c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.github/workflows/w3c_interop.yml:34
actions/cachecache key and restore key reference${{ matrix.otp_version }}, but this job does not define astrategy.matrix, somatrixwill be undefined at runtime and the workflow will fail expression evaluation. Use a literal OTP version (sincesetup-beamis pinned to26.1.2here) or introduce a matrix/env var and reference that instead.
path: |
_build
key: ${{ runner.os }}-build-${{ matrix.otp_version }}-${{ hashFiles('rebar.lock') }}-1
restore-keys: |
${{ runner.os }}-build-${{ matrix.otp_version }}-1-
Tracked in open-telemetry/sig-security#293.
Adds zizmor scanning through the OpenTelemetry shared workflow.
The workflow:
regularpersona on pull requests, pushes tomain, and a randomized weekly schedule;After merge
zizmorcode-scanning result.If enforcement unexpectedly blocks a valid change, restore
require_zizmor = falseinopen-telemetry/adminwhile leaving scanning enabled.