Skip to content

[Infra] .NET 11 preparation - #4849

Merged
martincostello merged 3 commits into
open-telemetry:mainfrom
martincostello:dotnet-11-preparation
Jul 28, 2026
Merged

[Infra] .NET 11 preparation#4849
martincostello merged 3 commits into
open-telemetry:mainfrom
martincostello:dotnet-11-preparation

Conversation

@martincostello

Copy link
Copy Markdown
Member

Changes

Cherry-pick changes from #3867 to fix new warnings and reduce the diff.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@github-actions github-actions Bot added documentation Improvements or additions to documentation comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva comp:instrumentation.confluentkafka Things related to OpenTelemetry.Instrumentation.ConfluentKafka comp:resources.host Things related to OpenTelemetry.Resources.Host labels Jul 21, 2026
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.39%. Comparing base (a58e551) to head (b6cc79c).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4849   +/-   ##
=======================================
  Coverage   77.39%   77.39%           
=======================================
  Files         468      468           
  Lines       19814    19810    -4     
=======================================
- Hits        15335    15332    -3     
+ Misses       4479     4478    -1     
Files with missing lines Coverage Δ
...ter.Geneva/Internal/Transports/EtwDataTransport.cs 89.47% <ø> (+3.11%) ⬆️
...rumentation.ConfluentKafka/InstrumentedProducer.cs 66.12% <ø> (ø)
src/OpenTelemetry.Resources.Host/HostDetector.cs 75.59% <ø> (-0.20%) ⬇️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 21, 2026

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-07-28 19:12 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@martincostello
martincostello marked this pull request as ready for review July 21, 2026 09:22
@martincostello
martincostello requested a review from a team as a code owner July 21, 2026 09:22
Copilot AI review requested due to automatic review settings July 21, 2026 09:22
@martincostello
martincostello enabled auto-merge July 21, 2026 09:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cherry-picks a small set of changes (from #3867) intended to reduce .NET 11-related build noise by addressing warnings and making minor refactors across a few components and examples.

Changes:

  • Simplify ETW transport code and related test assertions/initialization to address analyzer warnings.
  • Make macOS host detector process timeout value explicit (reducing “magic number”/warning churn).
  • Adjust conditional compilation around Type.FullName nullability to avoid new warnings on newer TFMs.
  • Update the ASP.NET example Web.config binding redirects.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/OpenTelemetry.Exporter.Geneva.Tests/Internal/Transports/EtwDataTransportTests.cs Updates test assertions and uses collection expressions for initialization.
src/OpenTelemetry.Resources.Host/HostDetector.cs Introduces a named timeout value for WaitForExit in macOS machine-id extraction.
src/OpenTelemetry.Instrumentation.ConfluentKafka/InstrumentedProducer.cs Uses conditional compilation to handle nullability warnings around Type.FullName.
src/OpenTelemetry.Exporter.Geneva/Internal/Transports/EtwDataTransport.cs Converts simple methods to expression-bodied members and suppresses an additional analyzer warning for an intentionally-unused parameter.
examples/AspNet/Web.config Adds an additional bindingRedirect entry (currently duplicated).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread examples/AspNet/Web.config Outdated
Comment thread examples/AspNet/Web.config Outdated
Remove duplicate binding redirect entry.
@github-actions github-actions Bot removed the documentation Improvements or additions to documentation label Jul 21, 2026
@martincostello martincostello added the keep-open Prevents issues and pull requests being closed as stale label Jul 21, 2026
@martincostello
martincostello added this pull request to the merge queue Jul 28, 2026
Merged via the queue into open-telemetry:main with commit da7c6b8 Jul 28, 2026
96 checks passed
@martincostello
martincostello deleted the dotnet-11-preparation branch July 28, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva comp:instrumentation.confluentkafka Things related to OpenTelemetry.Instrumentation.ConfluentKafka comp:resources.host Things related to OpenTelemetry.Resources.Host keep-open Prevents issues and pull requests being closed as stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants