[Infra] .NET 11 preparation - #4849
Merged
martincostello merged 3 commits intoJul 28, 2026
Merged
Conversation
Cherry-pick changes from open-telemetry#3867.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4849 +/- ##
=======================================
Coverage 77.39% 77.39%
=======================================
Files 468 468
Lines 19814 19810 -4
=======================================
- Hits 15335 15332 -3
+ Misses 4479 4478 -1
🚀 New features to boost your workflow:
|
Pull request dashboard statusMerged · refreshed 2026-07-28 19:12 UTC Status above doesn't look right?
|
martincostello
marked this pull request as ready for review
July 21, 2026 09:22
martincostello
enabled auto-merge
July 21, 2026 09:22
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cherry-picks a small set of changes (from #3867) intended to reduce .NET 11-related build noise by addressing warnings and making minor refactors across a few components and examples.
Changes:
- Simplify ETW transport code and related test assertions/initialization to address analyzer warnings.
- Make macOS host detector process timeout value explicit (reducing “magic number”/warning churn).
- Adjust conditional compilation around
Type.FullNamenullability to avoid new warnings on newer TFMs. - Update the ASP.NET example
Web.configbinding redirects.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/OpenTelemetry.Exporter.Geneva.Tests/Internal/Transports/EtwDataTransportTests.cs | Updates test assertions and uses collection expressions for initialization. |
| src/OpenTelemetry.Resources.Host/HostDetector.cs | Introduces a named timeout value for WaitForExit in macOS machine-id extraction. |
| src/OpenTelemetry.Instrumentation.ConfluentKafka/InstrumentedProducer.cs | Uses conditional compilation to handle nullability warnings around Type.FullName. |
| src/OpenTelemetry.Exporter.Geneva/Internal/Transports/EtwDataTransport.cs | Converts simple methods to expression-bodied members and suppresses an additional analyzer warning for an intentionally-unused parameter. |
| examples/AspNet/Web.config | Adds an additional bindingRedirect entry (currently duplicated). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
martincostello
commented
Jul 21, 2026
Remove duplicate binding redirect entry.
github-actions
Bot
requested review from
Kielek,
g7ed6e,
lachmatt,
rajkumar-rangaraj and
xiang17
July 21, 2026 09:31
rajkumar-rangaraj
approved these changes
Jul 28, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Cherry-pick changes from #3867 to fix new warnings and reduce the diff.
Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)