ci: verify semantic conventions generation - #4769
Open
ihopenre-eng wants to merge 4 commits into
Open
Conversation
Contributor
|
Welcome, contributor! Thank you for your contribution to opentelemetry-dotnet-contrib. Important reminders:
|
Pull request dashboard statusWaiting on the author · refreshed 2026-08-14 16:20 UTC Two things need attention:
Status above doesn't look right?
|
Signed-off-by: ihopenre-eng <247072151+ihopenre-eng@users.noreply.github.com>
Signed-off-by: ihopenre-eng <247072151+ihopenre-eng@users.noreply.github.com>
ihopenre-eng
force-pushed
the
ci/verify-semantic-conventions-generation
branch
from
July 21, 2026 16:10
627d67d to
3443aef
Compare
| - name: Verify generated files are up to date | ||
| shell: pwsh | ||
| run: | | ||
| $generatedFiles = git status --short --untracked-files=all -- ./src/OpenTelemetry.SemanticConventions/Attributes |
Member
There was a problem hiding this comment.
Looks like this is writing the output to the wrong place based on the file permission issues. The output path should be constructed using the absolute path with $GITHUB_WORKSPACE instead of using .
Member
There was a problem hiding this comment.
@ihopenre-eng, you have resolved this conversatoion, but it seems to be valid. Can you look into this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2068
Design discussion issue #2068
Changes
Validation
go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.12 -coloryamllint --no-warningsagainst the staged workflowmarkdownlint-cli2 src/OpenTelemetry.SemanticConventions/README.mdgenerate.ps1The new CI job performs the Docker-based Weaver regeneration on Ubuntu.
Merge requirement checklist
CHANGELOG.mdfiles updated (not applicable; this is CI infrastructure)