Skip to content

ci: verify semantic conventions generation - #4769

Open
ihopenre-eng wants to merge 4 commits into
open-telemetry:mainfrom
ihopenre-eng:ci/verify-semantic-conventions-generation
Open

ci: verify semantic conventions generation#4769
ihopenre-eng wants to merge 4 commits into
open-telemetry:mainfrom
ihopenre-eng:ci/verify-semantic-conventions-generation

Conversation

@ihopenre-eng

Copy link
Copy Markdown

Fixes #2068
Design discussion issue #2068

Changes

  • consolidate semantic convention generation on the cross-platform PowerShell script, removing duplicate version pins
  • add a CI job that regenerates into a clean output directory and fails when committed files differ
  • update the generation documentation for the single supported command

Validation

  • go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.12 -color
  • yamllint --no-warnings against the staged workflow
  • markdownlint-cli2 src/OpenTelemetry.SemanticConventions/README.md
  • PowerShell AST parsing for generate.ps1

The new CI job performs the Docker-based Weaver regeneration on Ubuntu.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (not applicable; this is CI infrastructure)
  • Appropriate CHANGELOG.md files updated (not applicable; this is CI infrastructure)
  • Changes in public API reviewed (not applicable; no public API changes)

@ihopenre-eng
ihopenre-eng requested a review from a team as a code owner July 16, 2026 05:03
@github-actions

Copy link
Copy Markdown
Contributor

Welcome, contributor! Thank you for your contribution to opentelemetry-dotnet-contrib.

Important reminders:

  • Read our Contributing Guidelines.
  • Sign the CLA if you haven't already.
  • Follow the OpenTelemetry Generative AI policy: disclose any AI use in your contribution, and communicate (PR descriptions, review replies) in your own words rather than AI-generated text.
  • Give reviewers at least a few days before pinging them for feedback.
  • If you need help with general setup, development process, or contributor etiquette, ask in #opentelemetry-new-contributors.

@github-actions github-actions Bot added infra Infra work - CI/CD, code coverage, linters comp:semanticconventions Things related to OpenTelemetry.SemanticConventions documentation Improvements or additions to documentation labels Jul 16, 2026
Comment thread .github/workflows/ci.yml
Comment thread src/OpenTelemetry.SemanticConventions/scripts/generate.sh
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 18, 2026

Copy link
Copy Markdown

Pull request dashboard status

Waiting on the author · refreshed 2026-08-14 16:20 UTC

Two things need attention:

  • Required checks are failing — investigate the failures.
  • 1 review item — respond to each (e.g. link a commit, explain why not, ask a follow-up):
    • Inline threads: 1
Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Should this be with reviewers? Comment /dashboard route:reviewers to route it to them.
  • Anything wrong — including the routing? Report it with what you expected; it helps us improve the dashboard.

Signed-off-by: ihopenre-eng <247072151+ihopenre-eng@users.noreply.github.com>
Signed-off-by: ihopenre-eng <247072151+ihopenre-eng@users.noreply.github.com>
@ihopenre-eng
ihopenre-eng force-pushed the ci/verify-semantic-conventions-generation branch from 627d67d to 3443aef Compare July 21, 2026 16:10
@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.50%. Comparing base (d73ea28) to head (d670154).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4769      +/-   ##
==========================================
- Coverage   77.56%   77.50%   -0.07%     
==========================================
  Files         468      468              
  Lines       19913    19913              
==========================================
- Hits        15445    15433      -12     
- Misses       4468     4480      +12     
Flag Coverage Δ
unittests-Contrib.Shared.Tests 90.26% <ø> (ø)
unittests-Exporter.Geneva 56.71% <ø> (+0.03%) ⬆️
unittests-Exporter.InfluxDB 97.96% <ø> (ø)
unittests-Exporter.OneCollector 95.60% <ø> (ø)
unittests-Extensions 90.61% <ø> (ø)
unittests-Extensions.Enrichment 100.00% <ø> (ø)
unittests-Extensions.Enrichment.AspNetCore 86.27% <ø> (ø)
unittests-Extensions.Enrichment.Http 94.33% <ø> (ø)
unittests-Instrumentation.AWS 85.35% <ø> (ø)
unittests-Instrumentation.AspNet 79.01% <ø> (ø)
unittests-Instrumentation.AspNetCore 87.20% <ø> (ø)
unittests-Instrumentation.Cassandra 92.30% <ø> (ø)
unittests-Instrumentation.ConfluentKafka 82.83% <ø> (ø)
unittests-Instrumentation.ElasticsearchClient 80.36% <ø> (ø)
unittests-Instrumentation.EntityFrameworkCore 81.02% <ø> (ø)
unittests-Instrumentation.EventCounters 75.45% <ø> (ø)
unittests-Instrumentation.GrpcCore 91.12% <ø> (ø)
unittests-Instrumentation.GrpcNetClient 78.09% <ø> (ø)
unittests-Instrumentation.Hangfire 88.88% <ø> (ø)
unittests-Instrumentation.Http 75.61% <ø> (ø)
unittests-Instrumentation.Kusto 92.42% <ø> (ø)
unittests-Instrumentation.Owin 89.02% <ø> (ø)
unittests-Instrumentation.Process 100.00% <ø> (ø)
unittests-Instrumentation.Quartz 77.77% <ø> (ø)
unittests-Instrumentation.Remoting 65.59% <ø> (ø)
unittests-Instrumentation.Runtime 100.00% <ø> (ø)
unittests-Instrumentation.ServiceFabricRemoting 39.91% <ø> (ø)
unittests-Instrumentation.SqlClient 82.86% <ø> (ø)
unittests-Instrumentation.StackExchangeRedis 94.98% <ø> (ø)
unittests-Instrumentation.Wcf 82.64% <ø> (ø)
unittests-OpAmp.Client 86.06% <ø> (-0.81%) ⬇️
unittests-PersistentStorage 67.74% <ø> (-1.47%) ⬇️
unittests-PowerShellScripts 86.27% <ø> (ø)
unittests-Resources.AWS 72.78% <ø> (ø)
unittests-Resources.Azure 84.18% <ø> (ø)
unittests-Resources.Container 80.76% <ø> (ø)
unittests-Resources.Gcp 80.70% <ø> (ø)
unittests-Resources.Host 72.34% <ø> (ø)
unittests-Resources.OperatingSystem 77.16% <ø> (ø)
unittests-Resources.Process 90.90% <ø> (ø)
unittests-Resources.ProcessRuntime 80.76% <ø> (ø)
unittests-Sampler.AWS 96.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread .github/workflows/ci.yml
- name: Verify generated files are up to date
shell: pwsh
run: |
$generatedFiles = git status --short --untracked-files=all -- ./src/OpenTelemetry.SemanticConventions/Attributes

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is writing the output to the wrong place based on the file permission issues. The output path should be constructed using the absolute path with $GITHUB_WORKSPACE instead of using .

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ihopenre-eng, you have resolved this conversatoion, but it seems to be valid. Can you look into this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:semanticconventions Things related to OpenTelemetry.SemanticConventions documentation Improvements or additions to documentation infra Infra work - CI/CD, code coverage, linters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Perform CI checks for auto-generated semantic conventions

3 participants