Make physical _from _to an object with properties#17
Merged
Conversation
vanous
changed the title
vanous
marked this pull request as draft
July 6, 2025 10:30
vanous
force-pushed
the
physical_values_redesign
branch
from
July 6, 2025 20:47
ea0cce5 to
6966fe0
Compare
vanous
changed the title
vanous
marked this pull request as ready for review
July 6, 2025 20:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to store more information related to the physical properties into the object. For starters, we need to know if the Channel Set's physical values originated in the set or are from the parent...
... after further working on usage of the data, currently, the rich PhysicalValue object is actually not needed, but i will already keep it this way and merge it in, as this provides better possible compatible improvements in the future.