fix(python): wire maximum_delay property setters (#539) - #540
Open
trippyogi wants to merge 2 commits into
Open
Conversation
maximum_delay, default_maximum_delay, and Confirmation.errors used def_property setters with no value argument, so every Python assignment raised TypeError. Wire setters to the real C++ overloads and add a unit test for setter arity plus Confirmation round-trip. Signed-off-by: Jeremy <peace@trippyogi.com>
trippyogi
force-pushed
the
fix/539-maximum-delay-setters
branch
from
August 3, 2026 22:26
c89cf5f to
7cbef0f
Compare
trippyogi
marked this pull request as ready for review
August 3, 2026 22:27
Contributor
|
@cardboardcode to review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
def_propertysetters forRobotUpdateHandle.maximum_delayandFleetUpdateHandle.default_maximum_delaythat took no value argument (every Python assignment raisedTypeError).Confirmation.errors.Closes #539
Test plan
rmf_fleet_adapter_pythontest_property_settershandle.maximum_delay = datetime.timedelta(seconds=5)succeeds