Skip to content

Add script inventory coverage tests - #2487

Closed
Dhruva162 wants to merge 1 commit into
open-quantum-safe:mainfrom
Dhruva162:main
Closed

Add script inventory coverage tests#2487
Dhruva162 wants to merge 1 commit into
open-quantum-safe:mainfrom
Dhruva162:main

Conversation

@Dhruva162

Copy link
Copy Markdown

Summary

This PR adds smoke and regression tests to improve coverage for scripts under scripts/.

Changes

  • Add an inventory test to ensure all scripts are covered by tests.
  • Add smoke/regression tests for previously uncovered Python and shell scripts.
  • Fix scripts/genkatdict.py by replacing json.dumps(...) with json.dump(...) so kats.json is correctly written.

Testing

py -3.12 -m pytest -q tests/test_alg_support_generators.py tests/test_scripts.py

@Dhruva162
Dhruva162 requested review from bhess and xuganyu96 as code owners July 2, 2026 16:06
Signed-off-by: Dhruva Vijayvargia <dhruvavijayvargia@gmail.com>
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 82.296% (+0.001%) from 82.295% — Dhruva162:main into open-quantum-safe:main

@xuganyu96

xuganyu96 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Please fix GitHub Actions failures.

Edit: this pull request is also a partial duplicate of #2466. I think it would be helpful for you to read #2466 decide if you want to rebase your test suite on top of that. Thank you

@xuganyu96

Copy link
Copy Markdown
Contributor

@Dhruva162 Please address the comments regarding test failures and #2466 duplication. This pull request will be closed for staleness if there is no response in a few days.

@Dhruva162

Copy link
Copy Markdown
Author

@Dhruva162 Please address the comments regarding test failures and #2466 duplication. This pull request will be closed for staleness if there is no response in a few days.

Thanks for the feedback. After reviewing #2466, I see there is significant overlap with my changes. Rather than duplicate effort, I'm happy to close this PR and work on a different issue or submit a follow-up PR for anything not covered there.

@Dhruva162 Dhruva162 closed this Jul 27, 2026
@Dhruva162 Dhruva162 reopened this Jul 27, 2026
@xuganyu96

Copy link
Copy Markdown
Contributor

Thanks for the feedback. After reviewing #2466, I see there is significant overlap with my changes. Rather than duplicate effort, I'm happy to close this PR and work on a different issue or submit a follow-up PR for anything not covered there.

Thank you for your time. I will close this pull request.

@xuganyu96 xuganyu96 closed this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants