Kyber/Dilithium fips versions -> standard branch - #1543
Merged
Conversation
8 tasks
baentsch
reviewed
Sep 8, 2023
baentsch
reviewed
Sep 8, 2023
baentsch
requested changes
Sep 8, 2023
baentsch
left a comment
Member
There was a problem hiding this comment.
Can I ask for a change to the version ID of the algs, please? Otherwise https://github.com/open-quantum-safe/oqs-provider/blob/main/oqs-template/oqs-sig-info.md for example will show the same algorithm "Implementation Version" for a different OID: Would be IMO pretty confusing.
Member
|
Thanks again for PR and updates -- I'd suggest to wait with merge until Sep 13 to see whether we really have to go this route (or a straight merge as per #1537 (comment) is preferred (@dstebila @cryptojedi ?) and we can avoid maintaining separate branches). If we need to do it, I'll then set up a separate branch in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to merge the Kyber/Dilithium (fips draft versions) to a standard branch. May be obsolete once #1537 is resolved.