common_types: don't typedef bool on C23 compilers#37
Open
runlevel5 wants to merge 1 commit into
Open
Conversation
In C23 (GCC 14+ defaults to -std=gnu23) bool is a built-in keyword, so
the `typedef uint8_t bool;` in common_types.h is now a hard error
("two or more data types in declaration specifiers") when host build
tools such as imageHdrScript are compiled with a modern host gcc.
Guard the typedef on __STDC_VERSION__ so it is kept for pre-C23
compilers and the PPE42 cross-toolchain, but skipped on C23+ where
bool is already defined.
Signed-off-by: Trung Lê <8@tle.id.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In C23 (GCC 14+ defaults to -std=gnu23) bool is a built-in keyword, so the
typedef uint8_t bool;in common_types.h is now a hard error ("two or more data types in declaration specifiers") when host build tools such as imageHdrScript are compiled with a modern host gcc.Guard the typedef on STDC_VERSION so it is kept for pre-C23 compilers and the PPE42 cross-toolchain, but skipped on C23+ where bool is already defined.