Repository navigation
OPA v1.19.0 - #2070
Merged
Merged
OPA v1.19.0#2070
Conversation
- Replace deprecated `test.WithTempFS` with `test.TempDir`. And adapt to the fact this doesn't write files with no content. Perhaps it should... 🤔 - Adapt tests to change in OPA which has location stripped from schema refs found in annotations - Try using `strings.split_n` in many places, but this often results in cache misses compared to `split` as we use it extensively - Use `util.Atoi` now provided by OPA Signed-off-by: Anders Eknert <anders.eknert@apple.com> Co-authored-by: Charlie Egan <charlie_egan@apple.com>
anderseknert
force-pushed
the
opa-v1.19.0
branch
from
August 4, 2026 15:06
3000157 to
50dd03f
Compare
Contributor
|
Replaces #2066 |
charlieegan3
approved these changes
Aug 5, 2026
Contributor
Yeah, I feel like there are cases, e.g. an empty regal config file or input.json that might be nice to have tests for. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test.WithTempFSwithtest.TempDir. And adapt to the fact this doesn't write files with no content. Perhaps it should... 🤔strings.split_nin many places, but this often results in cache misses compared tosplitas we use it extensivelyutil.Atoinow provided by OPAThanks @charlieegan3 for the pointer / work on Go 1.27 support!