Skip to content

fix the problems with project sharing#478

Merged
paulapreuss merged 26 commits into
mainfrom
fix/sharing_rights
Jul 1, 2026
Merged

fix the problems with project sharing#478
paulapreuss merged 26 commits into
mainfrom
fix/sharing_rights

Conversation

@josihoppe

Copy link
Copy Markdown
  • add decorator to use in views instead of repeating checks for user / viewer
  • check the problems described in:
  • adjust sharing rights for these problems

@josihoppe josihoppe requested a review from paulapreuss May 26, 2026 14:25
Comment thread app/dashboard/views.py Outdated
@josihoppe josihoppe marked this pull request as ready for review June 17, 2026 09:45
@paulapreuss

paulapreuss commented Jun 18, 2026

Copy link
Copy Markdown

@josihoppe Code looks nice, thanks for this refactoring! I think it will really improve maintenance regarding this topic ✨

I tested around a bit sharing with myself and I noticed the following:

  • If I have a project with read rights, I can still update the parameters on the assets in the energy system (asset_create_or_update). Once I do that, I am also able to restart the simulation. If there is no simulation on the scenario yet, I am also able to start a simulation. I only get a 403 if I try to reset the existing simulation with no parameters changed. That shouldn't be possibe just with read rights.
  • If a project is shared with me (both for edit and read rights), I do not see the button for project deletion, so I can't actually remove the project again from the projects view, although in the backend now it should work to just revoke the access.

After these things are fixed, I will rebase on main and hopefully have fixed the build dependencies and update the changelog before we merge.

josihoppe and others added 25 commits July 1, 2026 12:13
@paulapreuss paulapreuss force-pushed the fix/sharing_rights branch from 26a6ae4 to f2e3a5a Compare July 1, 2026 10:14
@paulapreuss paulapreuss merged commit 1faf0cd into main Jul 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Graphs for the uploaded timeseries are not visible in a shared project

2 participants