Repository navigation
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
RustQ version requirement CHANGELOG.md, README.md, guides/native-decoders.md, integration/generator_consumer/mix.exs, mix.exs |
Dependency constraints and documentation now specify RustQ ~> 1.0.0-rc.21. The optional local-path override remains unchanged. |
Generated helper expressions codegen/kiwi_codec/rustler_generator/*/helpers.ex, test/kiwi_codec/rustler_generator_test.exs |
Full, skip, and sparse helpers pass arrays and indexed fields directly. The test module no longer declares the @runtime source attribute. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Refactor
Possibly related PRs
- open-pencil/kiwi_codec#8: Introduces the RustQ helper modules that this change updates for rc.21.
- open-pencil/kiwi_codec#2: Introduces generated full-decoder expressions that this change updates for rc.21.
Merge Risk: 
Minimal · up to 9c509
-
No actionable regression introduced by this PR remains.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 5 files. (3 skipped: 3 unsupported.)
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
With RustQ 1.0.0-rc.21 the generator's helpers drop most explicit borrows:
ref(array([...]))arguments are plain lists, borrowed as slices.fields.get(index).unwrap()andref(index(fields, index))areindex(fields, index), borrowed because the items are notCopy.ref(index(fields, index).kind)isindex(fields, index).kind.ref(values)intomake_struct_from_arraysisvalues.The generated Rust is unchanged apart from
make_struct_from_arrays(env, keys, &values)(was&&values) and&fields[index](wasfields.get(index).unwrap()). Borrows into Rustler's ownmap_from_term_arraysandderefof a raw function pointer stay, since RustQ has no types for them.Also removes an unused
@runtimeattribute from the native test.Summary by CodeRabbit
~> 1.0.0-rc.21.