fix: broaden permissions for attestations - #11
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions release workflow to support artifact attestations/metadata and ensure the changelog generation step has full repository context during release publishing.
Changes:
- Broadened job permissions in the
sbomsjob to allow writing artifact metadata. - Ensured the
changelogjob runs with a full checkout via the reusable workflow input. - Updated pinned SHAs for several third-party GitHub Actions used during the release upload flow.
Comments suppressed due to low confidence (1)
.github/workflows/release.yml:247
actions/upload-artifactis pinned here to a different SHA/version than the repo’s other workflows (notably.github/workflows/run-reusable.yml, which still uses a v4.x pin). If the bump is intentional, consider updating the shared reusable workflow too (or documenting why this job needs a different version) to avoid inconsistent artifact upload behavior.
- name: "Upload artifacts"
# enq: hash with name and version always longer than 80 chars
# yamllint disable rule:line-length
uses: "actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a" # v7.0.1
# yamllint enable rule:line-length
with:
name: "dist-${{ github.sha }}"
path: "dist"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
204
to
210
| - name: "Download artifacts" | ||
| # enq: hash with name and version always longer than 80 chars | ||
| # yamllint disable rule:line-length | ||
| uses: "actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093" # v4.3.0 | ||
| uses: "actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c" # v8.0.1 | ||
| # yamllint enable rule:line-length | ||
| with: | ||
| name: "dist-${{ github.sha }}" |
Signed-off-by: szymonmaszke <github@maszke.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist