Skip to content

fix(fork): green the ownership coverage check on main - #967

Merged
Deeds67 merged 1 commit into
mainfrom
fix/fork-ownership-manifest-green
Aug 10, 2026
Merged

fix(fork): green the ownership coverage check on main#967
Deeds67 merged 1 commit into
mainfrom
fix/fork-ownership-manifest-green

Conversation

@Deeds67

@Deeds67 Deeds67 commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

make fork-ownership-coverage-check currently fails on main with two errors:

Ownership manifest last_verified_fork_head e60a6616a0f4… is not an ancestor of 99ce9f8b46e7…;
reconcile docs/fork/ownership.yml before rebasing.
Ownership manifest does not cover 1 fork files:
Template/Stack/noodle-gallery.yml

Changes

Verification

Check Before After
make fork-ownership-coverage-check exit 1, 2 errors exit 0 — covers 3321 fork files
make ci-invariants-check exit 0, 3/3 invariants
make fork-patches-check exit 0
prettier --check docs/fork/ownership.yml clean

tools/upstream-preflight tests: 232/235. The 3 batch.spec.ts failures reproduce identically on
an unmodified tree and test.yml is green on main at the same SHA, so they are local-environment
only and untouched here.

Notes

The cursor bump is a treadmill, not a cure — the next rebase orphans 99ce9f8b46e the same way, and
this is the third recorded occurrence. Keying the cursor on something rebase-stable would fix the
class; that is a design change and deliberately out of scope here.

None of these checks run in CI today (they fire only when a rebase starts), so main can drift red
again unnoticed. Wiring the three cheap ones into test.yml is a separate follow-up.

`make fork-ownership-coverage-check` fails on main with two errors:

- `last_verified_fork_head` (`e60a6616a0f`, #777) is not an ancestor of
  `origin/main`. Every upstream rebase rewrites fork SHAs, so the cursor
  orphans itself each cycle.
- `Template/Stack/noodle-gallery.yml` (#942) is a new top-level directory
  that no glob covers.

Declare `Template/**` under `release-ci-and-infrastructure` (fork-only —
absent from `upstream/main`) and bump the cursor to current `origin/main`.
@Deeds67 Deeds67 added the changelog:chore Chore/maintenance for changelog label Aug 10, 2026
@Deeds67
Deeds67 merged commit 92e13b8 into main Aug 10, 2026
44 of 45 checks passed
Deeds67 added a commit that referenced this pull request Aug 10, 2026
`make fork-ownership-coverage-check` fails on main with two errors:

- `last_verified_fork_head` (`e60a6616a0f`, #777) is not an ancestor of
  `origin/main`. Every upstream rebase rewrites fork SHAs, so the cursor
  orphans itself each cycle.
- `Template/Stack/noodle-gallery.yml` (#942) is a new top-level directory
  that no glob covers.

Declare `Template/**` under `release-ci-and-infrastructure` (fork-only —
absent from `upstream/main`) and bump the cursor to current `origin/main`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:chore Chore/maintenance for changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant