Fix syncbn training state - #1695
Open
Marchematics wants to merge 5 commits into
Open
Conversation
Signed-off-by: Marchematics <Marchematics@163.com>
Marchematics
force-pushed
the
fix-syncbn-training-state
branch
from
August 31, 2026 20:09
57be875 to
8b1dbfb
Compare
Author
|
Removed the duplicate |
Author
|
Targeted regression test passes: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Preserve the source module's training mode when converting
BatchNormtoSyncBatchNorm. Without this, evaluation-mode layers are silently switched to training mode, which can cause incorrect fine-tuning behavior and NCCL timeouts. Fixes #1624.Modification
Copy
module.trainingto the converted module and add a regression test for evaluation-mode conversion.BC-breaking
No.
Checklist
test_convert_sync_batchnorm_keeps_training_state.