-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Fixes 31756: return parent glossary terms on child fields; stop delete cascade stripping manual labels #31834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mohityadav766
wants to merge
34
commits into
main
Choose a base branch
from
glossary-derived-tag-propagation-bugs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
96a68c6
fix(tags): return parent glossary terms on child fields and stop the …
mohityadav766 f4e16f5
Merge branch 'main' into glossary-derived-tag-propagation-bugs
mohityadav766 5223341
test(tags): cover the child glossary term projection, and stop a proj…
mohityadav766 4335616
Merge branch 'main' into glossary-derived-tag-propagation-bugs
mohityadav766 6ef706e
fix(tags): rebuild column search docs when a table's tags change
mohityadav766 d5728eb
Merge branch 'main' into glossary-derived-tag-propagation-bugs
mohityadav766 37f2155
Merge branch 'main' into glossary-derived-tag-propagation-bugs
mohityadav766 14fa0dc
fix(tags): drive the child cascade from the bulk asset APIs and stop …
mohityadav766 c203168
Merge branch 'main' into glossary-derived-tag-propagation-bugs
mohityadav766 f7ebf30
fix(ui): apply checkstyle formatting and drop the Metric CSV change
mohityadav766 a73372c
Merge remote-tracking branch 'origin/main' into glossary-derived-tag-…
mohityadav766 efdb833
chore(playwright): auto-refresh impact-map.generated.json
github-actions[bot] 458499e
Merge remote-tracking branch 'origin/main' into glossary-derived-tag-…
harshach ca5514e
fix(search): propagate glossary tags to test time series
harshach 62ca0a0
fix(search): discard stale tag deltas during retry
harshach 2d6c3e5
Merge branch 'main' into glossary-derived-tag-propagation-bugs
harshach 1b500d3
Merge branch 'main' into glossary-derived-tag-propagation-bugs
harshach 77e15b4
fix(search): avoid column reindex for table tags
harshach 4b46a49
fix(ui): handle unresolved tree select tags
harshach b0ed6c0
Merge branch 'main' into glossary-derived-tag-propagation-bugs
mohityadav766 3960316
Merge branch 'main' into glossary-derived-tag-propagation-bugs
harshach 8c8fb41
Merge branch 'main' into glossary-derived-tag-propagation-bugs
harshach 278a845
Merge branch 'main' into glossary-derived-tag-propagation-bugs
mohityadav766 b3e24e6
Merge branch 'main' into glossary-derived-tag-propagation-bugs
harshach ea021ea
Merge remote-tracking branch 'origin/main' into glossary-derived-tag-…
mohityadav766 848b6f2
fix(tags): derive propagated glossary terms in time-series indexes
mohityadav766 07f6cef
Merge branch 'main' into glossary-derived-tag-propagation-bugs
mohityadav766 ef831c7
Merge branch 'main' into glossary-derived-tag-propagation-bugs
mohityadav766 ccfe6c8
Merge branch 'main' into glossary-derived-tag-propagation-bugs
harshach dac302e
Merge remote-tracking branch 'origin/main' into glossary-derived-tag-…
mohityadav766 981fdca
Merge remote-tracking branch 'origin/glossary-derived-tag-propagation…
mohityadav766 9d7774c
Merge remote-tracking branch 'origin/main' into glossary-derived-tag-…
mohityadav766 6873415
Merge branch 'main' into glossary-derived-tag-propagation-bugs
mohityadav766 16e6101
chore(playwright): auto-refresh impact-map.generated.json
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
510 changes: 510 additions & 0 deletions
510
...egration-tests/src/test/java/org/openmetadata/it/tests/GlossaryTagChildPropagationIT.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validateColumnTagscallsaddDerivedTagsand thencheckMutuallyExclusiveForUserAppliedTags. That check now drops both DERIVED and PROPAGATED labels, so the classification tags derived from a glossary term are never checked. Before this change, putting glossary term G (which carriesPII.Sensitive) on a column together with a manualPII.NonSensitivewas rejected, and so were two terms whose derived tags conflict. Both combinations are now accepted and stored. The same applies to theupdateTagsPUT and PATCH paths at lines 9824 and 9843. The GET→PUT round-trip problem described in the javadoc comes only from PROPAGATED projections. The fix is to exclude only PROPAGATED (inherited from the parent) labels from this check and keep DERIVED labels in it, since they come from the entity's own glossary terms.In TagLabelUtil, filter out only PROPAGATED so that derived-tag conflicts are still rejected:
Check the box to apply the fix or reply for a change | Was this helpful? React with 👍 / 👎