Skip to content

fix(test): prevent flaky OktaSessionRenewalPublic second test #31830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rohit0301 merged 4 commits into from
Aug 21, 2026
+7 −1
Merged

fix(test): prevent flaky OktaSessionRenewalPublic second test #31830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
af76108
fix(test): prevent flaky Okta silent-renewal fallback test by navigat…
Rohit0301 Aug 20, 2026
7f1ac90
Merge branch 'main' into sso-okta-silent-renewal-flaky
Rohit0301 Aug 20, 2026
cdeb7ca
feat(test): enable trace always for sso-auth Playwright project
Rohit0301 Aug 20, 2026
3a2443a
fix(test): use retain-on-failure trace for sso-auth to capture first …
Rohit0301 Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openmetadata-ui/src/main/resources/ui/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ export default defineConfig({
'**/SSORenewal.spec.ts',
'**/SSOSessionLimit.spec.ts',
],
use: { ...devices['Desktop Chrome'] },
use: { ...devices['Desktop Chrome'], trace: 'retain-on-failure' },
fullyParallel: false,
workers: 1,
},
Expand Down
6 changes: 6 additions & 0 deletions openmetadata-ui/src/main/resources/ui/playwright/e2e/Auth/OktaSessionRenewalPublic.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
*/
import { BrowserContext, expect, Page, Request, test } from '@playwright/test';
import { SSO_ENV } from '../../constant/ssoAuth';
import { redirectToHomePage } from '../../utils/common';
import { decodeJwtExp, expireStoredToken } from '../../utils/sessionRenewal';
import { getProviderHelper, ProviderHelper } from '../../utils/sso-providers';
import { swapSecurityConfig } from '../../utils/ssoAuth';
Expand Down Expand Up @@ -140,6 +141,11 @@ test.describe('Okta Public Session Renewal', { tag: OKTA_PUBLIC_TAGS }, () => {

await expect(page.getByTestId('dropdown-profile')).toBeVisible();

// Test 1 ends on the Explore page. Navigating home ensures the subsequent
// app-bar-item-explore click is always a real navigation that triggers an
// API call, a 401, and the renewal flow we are testing.
await redirectToHomePage(page);

// renewToken reaches signInWithRedirect() both from the catch around
// renewTokens() and from an early return when okta-auth-js holds no tokens.
// Ordering is what distinguishes them.
Expand Down
Loading