Skip to content

bump react-router 7.18.1 -> 7.18.2 - #31826

Merged
Rohit0301 merged 2 commits into
mainfrom
bump-react-router
Aug 21, 2026
Merged

bump react-router 7.18.1 -> 7.18.2#31826
Rohit0301 merged 2 commits into
mainfrom
bump-react-router

Conversation

@Rohit0301

@Rohit0301 Rohit0301 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Describe your changes:

Fixes #

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Greptile Summary

The PR upgrades react-router-dom and its transitive react-router package from 7.18.1 to 7.18.2.

  • Keeps the application dependency pinned to an exact version.
  • Updates matching resolved URLs, integrity hashes, and transitive version references in yarn.lock.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
openmetadata-ui/src/main/resources/ui/package.json Updates the exact react-router-dom dependency pin from 7.18.1 to 7.18.2.
openmetadata-ui/src/main/resources/ui/yarn.lock Consistently locks react-router-dom and react-router to 7.18.2 with updated registry URLs and integrity hashes.

Reviews (2): Last reviewed commit: "Merge branch 'main' into bump-react-rout..." | Re-trigger Greptile

@Rohit0301 Rohit0301 self-assigned this Aug 20, 2026
@Rohit0301 Rohit0301 added the safe to test Add this label to run secure Github workflows on PRs label Aug 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added the UI UI specific issues label Aug 20, 2026
@Rohit0301 Rohit0301 added safe to test Add this label to run secure Github workflows on PRs and removed safe to test Add this label to run secure Github workflows on PRs labels Aug 20, 2026
@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit fab4d2c32940e78df3047846c694f4d80b4600f7 in Playwright run 32365080272, attempt 1.

✅ 551 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 49m 23s

⏱️ Max setup 5m 11s · max shard execution 15m 6s · max shard-job elapsed before upload 18m 50s · reporting 4s

🌐 214.64 requests/attempt · 2.83 app boots/UI scenario · 13.25% common-shard skew

Optimization targets still in progress:

  • Browser traffic was 214.64 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.83 per UI scenario (1618 boots / 572 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 102 0 0 0 0 0
✅ Shard chromium-02 95 0 0 0 0 0
✅ Shard chromium-03 100 0 0 0 0 0
✅ Shard chromium-04 102 0 0 0 0 0
✅ Shard data-asset-rules-01 61 0 0 0 0 0
✅ Shard domain-isolation-01 14 0 0 0 0 0
✅ Shard global-state-01 34 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 11 0 0 0 0 0
✅ Shard search-rbac-01 29 0 0 0 0 0

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 66%
66.96% (80268/119867) 51.39% (49123/95579) 52.35% (14667/28014)

@sonarqubecloud

Copy link
Copy Markdown

@Rohit0301
Rohit0301 added this pull request to the merge queue Aug 21, 2026
Merged via the queue into main with commit 2ed4e91 Aug 21, 2026
91 of 93 checks passed
@Rohit0301
Rohit0301 deleted the bump-react-router branch August 21, 2026 08:12
@gitar-bot

gitar-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Bumps react-router from version 7.18.1 to 7.18.2. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants