Skip to content

MINOR: mark the IOMETE connector as beta in the UI - #31821

Queued
ulixius9 wants to merge 1 commit into
mainfrom
auckland-v1
Queued

MINOR: mark the IOMETE connector as beta in the UI#31821
ulixius9 wants to merge 1 commit into
mainfrom
auckland-v1

Conversation

@ulixius9

@ulixius9 ulixius9 commented Aug 20, 2026

Copy link
Copy Markdown
Member

Describe your changes:

I added DatabaseServiceType.Iomete to BETA_SERVICES in ServiceType.constant.ts because the IOMETE database connector is not yet GA and should carry the same "Beta" pill as the other pre-GA connectors. BETA_SERVICES is the single source of truth for that badge — its only consumer is SelectServiceType.tsx, which renders the pill on each connector card in the Add Service picker — so this one-line addition is the complete change.

Type of change:

  • Improvement

High-level design:

N/A — one-line addition to an existing constant list.

Tests:

Use cases covered

  • Admin opening Settings → Services → Databases → Add New Service sees a "Beta" pill on the IOMETE connector card, alongside the existing beta connectors (Dremio, StarRocks, QuestDB, …).
  • The pill also shows in the "All" connector view, which spans every service category.

Unit tests

Not applicable — no new logic; the change is a new entry in an existing constant array. The rendering branch (BETA_SERVICES.includes(type)) is unchanged and already exercised by the existing beta connectors.

Backend integration tests

  • Not applicable (no backend API changes).

Ingestion integration tests

  • Not applicable (no ingestion changes).

Playwright (UI) tests

Not applicable — no new UI behaviour, only one more connector matching an existing render branch.

Manual testing performed

Not run — this worktree has no node_modules under openmetadata-ui/src/main/resources/ui/, so the dev server / lint suite could not be started here. Verified statically instead:

  1. DatabaseServiceType.Iomete is a real generated enum member (src/generated/entity/services/databaseService.ts), so the new entry type-checks.
  2. grep -rn "BETA_SERVICES" across the repo returns exactly one definition and one consumer (SelectServiceType.tsx:197), confirming no other list needs the same entry.
  3. The label.beta i18n key already exists in the locale catalogs, so no yarn i18n run is needed.

UI screen recording / screenshots:

TODO — attach a screenshot of the Add Service picker showing the "Beta" pill on the IOMETE card.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation> — pending the linked issue.
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above — pending.
  • I have commented on my code, particularly in hard-to-understand areas — N/A, no new logic.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed — N/A, no schema change.
  • For UI changes: I attached a screen recording and/or screenshots above — TODO.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above — none applicable, explained above.

🤖 Generated with Claude Code

Greptile Summary

Adds IOMETE to the UI’s beta-service list so its connector card displays the existing “Beta” badge in the Add Service picker.

Confidence Score: 5/5

The PR appears safe to merge with no actionable code issues identified.

The IOMETE enum value matches the service-picker value, remains available in the picker, and the changed list controls only display of the intended beta badge.

Important Files Changed

Filename Overview
openmetadata-ui/src/main/resources/ui/src/constants/ServiceType.constant.ts Correctly adds the generated IOMETE database service enum to the list used exclusively for beta-badge rendering.

Reviews (1): Last reviewed commit: "MINOR: mark the IOMETE connector as beta..." | Re-trigger Greptile

Context used:

Add DatabaseServiceType.Iomete to BETA_SERVICES so the Add Service
connector picker renders the "Beta" pill on the IOMETE card.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 20, 2026 09:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Aug 20, 2026
@gitar-bot

gitar-bot Bot commented Aug 20, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Adds the IOMETE database service type to the BETA_SERVICES constant array to display the beta badge in the UI service picker. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ UI Checkstyle passed — lint findings in changed files

🔍 ESLint findings in this PR's files — 0 error(s), 1 warning(s)

Errors block the build. Warnings do not yet — they are rules whose backlog is still
being worked down, listed so this PR does not add to it. See docs/ui-code-quality-gate.md.

0 error(s), 1 warning(s) across 1 changed file(s).

Count Rule
1 sonarjs/no-duplicate-string
All findings
Location Rule Message
🟡 src/constants/ServiceType.constant.ts:73:28 sonarjs/no-duplicate-string Define a constant instead of duplicating this literal 12 times.

Fix locally (fast - only checks files changed in this branch):

make ui-checkstyle-changed

@github-actions

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 66%
66.95% (80238/119835) 51.37% (49080/95528) 52.34% (14663/28010)

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 04e8f1f225bdc0ba9ecf60567b899407367f9290 in Playwright run 32353063033, attempt 1.

✅ 551 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 50m 32s

⏱️ Max setup 5m 9s · max shard execution 14m 28s · max shard-job elapsed before upload 18m 16s · reporting 4s

🌐 214.44 requests/attempt · 2.83 app boots/UI scenario · 21.31% common-shard skew

Optimization targets still in progress:

  • Common shard skew was 21.31% (convergence target: at most 15%).
  • Browser traffic was 214.44 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.83 per UI scenario (1619 boots / 572 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 103 0 0 0 0 0
✅ Shard chromium-02 108 0 0 0 0 0
✅ Shard chromium-03 100 0 0 0 0 0
✅ Shard chromium-04 88 0 0 0 0 0
✅ Shard data-asset-rules-01 61 0 0 0 0 0
✅ Shard domain-isolation-01 14 0 0 0 0 0
✅ Shard global-state-01 34 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 11 0 0 0 0 0
✅ Shard search-rbac-01 29 0 0 0 0 0

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@ulixius9
ulixius9 added this pull request to the merge queue Aug 20, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ingestion safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants