actions: smoother labelling triggers - #10388
Open
dogi wants to merge 1 commit into
Open
Conversation
`edited` fires on every title or description rewrite, so coderabbit's walkthrough alone queued several extra runs per pull request. Each one entered the labels-<pr> concurrency group, cancelled the labelling run still in flight, and then skipped on the base-change guard -- leaving a push unlabelled behind a row of skipped checks. Label on the events that change the diff instead, and drop the guard the `edited` trigger needed. Retargeting a pull request still changes its diff without a push; the workflow_dispatch input relabels it by hand. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CsgFLJCRY6VhZrkN27EBib
dogi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
editedevent type from thepull_request_targettrigger in the planet labels workflow and simplifies the conditional logic that was working around it.Changes
editedfrom workflow trigger types: The workflow now only runs onopened,synchronize,reopened, andready_for_reviewevents. Theeditedevent was causing excessive workflow runs whenever CodeRabbit or other tools rewrote PR titles/descriptions, leading to cascading cancellations and skipped labelling checks.if: ${{ github.event.action != 'edited' || github.event.changes.base }}condition that was attempting to skip runs on edits (except retargeting). This is no longer needed since the trigger itself excludes theeditedevent.Rationale
The
editedevent fires on every title or description rewrite. CodeRabbit rewrites PR descriptions multiple times, which queued multiple workflow runs that cancelled each other and resulted in PRs remaining unlabelled. Manual relabelling viaworkflow_dispatchis available for retargeted PRs (which change the diff without a push).https://claude.ai/code/session_01CsgFLJCRY6VhZrkN27EBib