Update def-actor to version 8 for jak3#4342
Merged
Merged
Conversation
v7 is copy/paste from jak2 https://github.com/open-goal/jak-project/blob/697337166da69af6515e97c5a9894b8ba2abc93c/goal_src/jak2/engine/data/art-h.gc#L423 https://github.com/open-goal/jak-project/blob/697337166da69af6515e97c5a9894b8ba2abc93c/goal_src/jak2/engine/load/file-io.gc#L109 but jak 3 is using v8 https://github.com/open-goal/jak-project/blob/697337166da69af6515e97c5a9894b8ba2abc93c/goal_src/jak3/engine/load/file-io.gc#L198-L199
Hat-Kid
requested changes
Jul 14, 2026
Co-authored-by: Hat Kid <6624576+Hat-Kid@users.noreply.github.com>
Hat-Kid
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v7 is copy/paste from jak2
jak-project/goal_src/jak2/engine/data/art-h.gc
Line 423 in 6973371
jak-project/goal_src/jak2/engine/load/file-io.gc
Line 109 in 6973371
but jak 3 uses v8
jak-project/goal_src/jak3/engine/load/file-io.gc
Lines 198 to 199 in 6973371