Repository navigation
fix(sim): tag server-estimated launch angles as estimated - #307
Merged
jewbetcha merged 1 commit intoOct 18, 2026
Merged
Conversation
When the radar has no launch angle, _ensure_user_facing_launch_angles fills in an estimate and marks its source "estimated". resolve_shot ignored the source and tagged any present angle, and the carry built on it, as measured. Read the source, and derive carry's tag from VLA's.
puiji
marked this pull request as ready for review
October 18, 2026 16:00
jewbetcha
approved these changes
Oct 18, 2026
Member
|
Thank you! |
HarjotDhanota
added a commit
to HarjotDhanota/openflight
that referenced
this pull request
Oct 20, 2026
…#305, open-flight#307) Conflicts: - server.py: upstream's mock-enrichment shortcut runs first, then our trace marks. - sim/resolver.py: both sides tagged estimated launch angles; ours keeps _resolve_carry, which already replaced the launch-angle carry badge (E4, C8). - tests/test_sim_resolver.py: both test sets kept; upstream's measured-VLA test now expects the estimated carry badge this fork gives an OPS-only carry. - tests/test_mock_hardware.py: the deadline publishes OPS-only, still pending, and the late enrichment finalizes the same shot (D29), not 'skipped'. - README.md: both contributor bullets kept. - AGENTS.md: the bench's master plan is linked by repository, not a local doc path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
resolve_shottags any launch angle it gets as measured, even when_ensure_user_facing_launch_anglesfilled it in and set its source to"estimated". It now readslaunch_angle_vertical_sourceandlaunch_angle_horizontal_source, and carry takes VLA's tag.Why was this required?
When the server fills in a launch angle, the simulator badges, the
sim_shotwebsocket event and thesim_sendsession-log entry say it, and the carry built on it, was measured. It's the launch-angle version of #271 (calculated spin). The code changes don't overlap.Automated tests
Two new tests in
tests/test_sim_resolver.pycover server-estimated VLA and HLA, and a measured VLA with an estimated HLA, which should keep carry measured. Both fail on main. Full suite passes.Manual (human) testing
I ran an OPS243-only 7-iron shot (no angle radar, no hardware) through the server's real
_ensure_user_facing_launch_anglesand_forward_shot_to_simulators, with a stub simulator connector.AI disclosure
Claude Code found this bug and drafted the fix, tests and description. I reviewed the changes and ran the tests and manual check myself.
Checklist
uv run pytest tests/ -v)uv run pylint src/openflight/ --fail-under=9)uv run ruff check src/openflight/)cd ui && npm run build)cd ui && npm run lint)