Repository navigation
build(deps): prevent Expo patch cooldown from blocking CI - #28
Open
johnpacino wants to merge 1 commit into
Open
johnpacino wants to merge 1 commit into
johnpacino wants to merge 1 commit into
Conversation
13 tasks done
|
I installed on my machine and tested and expo doctor no longer passes. The versions are stale as of Oct. 6th due to Expo SDK 57 patches. #31 addresses why the expo-doctor breakage keeps coming back and breaking CI. With #31 the normal Dependabot schedule is enough imo. More details and test results there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
expoto~57.0.25expo-linkingto~57.0.11expo-routerto~57.0.23expo,expo-*, and@expo/*packages to update immediately.Why was this required?
Expo Doctor began requiring these newly released patches immediately, causing the required
Qualitycheck on unrelated PRs to fail. Dependabot found the same releases but filtered them out under GitHub's default three-day release cooldown, so manually requesting an update produced no PR.The current package alignment restores green CI. Exempting only Expo-owned packages from cooldown aligns future Dependabot behavior with Expo Doctor without removing the stabilization delay for the rest of the dependency graph. Daily checks reduce the remaining delay between an Expo baseline change and the grouped lockfile PR.
Evidence: Dependabot update job and the
Qualityfailure on #27.Automated tests
No application tests were added because this changes dependency automation and SDK-compatible patch versions without changing application behavior.
Commands run:
npm ci— passednpm run doctor— 21/21 checks passedCI=1 npx expo install --check— dependencies are up to datenpm run lint— passednpm run format:check— passednpm run typecheck— passednpm run test:ci— 18 suites and 262 tests passed on the isolated rerunnpm run bundle:check— iOS, Android, and web exports passedThe first full-suite run was executed concurrently with the three-platform bundle and one existing Device-screen test exceeded its five-second timeout. The immediate isolated rerun passed all 262 tests.
Manual (human) testing
Not performed. No physical device, simulator, or Expo Go session was used because this is dependency automation and compatible patch alignment only.
Server/API contract impact
None.
AI assistance
Codex inspected the GitHub and Dependabot job logs, identified the cooldown mismatch, prepared the focused configuration and dependency changes, removed unrelated lockfile churn, and ran the validation listed above. Human review of the final diff is pending.
Checklist
npm cisucceedsnpx expo-doctorpassesnpx tsc --noEmitpassesnpm test -- --ci --runInBandpassesnpx expo export --platform allsucceeds when application code changed