fix(v0.44): small correctness sweep for Beta admission (#1220) - #1258
Merged
Conversation
Alpha.10 truth closure. Amendment authority: ADR-0151 (touches ADR-0122 §4 frozen path packages/adapter-vite/src/cli/start.ts). - M4 VOID_TAGS: one canonical definition (html-escape.ts, full HTML Standard list incl. 'param'); server/runtime import it; the sanitize twin and the two program.ts exchange artifacts stay documented byte-mirrors pinned by a guard test - L1 escapeAttr: runtime and server serializers converge on the single canonical escape (previously byte-divergent DSD attribute output) - M8: start.ts request callback delegates to a contained handler in internal/static-serve.ts — sync throw / rejection / write failure become a contained 500 instead of an unhandledRejection crash - M13: build-ssg uses pathToFileURL (spaces/#/?/non-ASCII paths import correctly; hostile test proves the old concat failed) - M3: guard test pins both when-operator evaluation sites and both validators to the closed 'greater-than' operator set (no claim edits) - version anchors: create/src/version.ts and www/app/data/version.ts are now value-anchored (3 new anchors; fixtures updated) Implemented by fresh kimi-code/k3-256k HIGH session (.agents/v044-kimi-implementer.md), packet A10.12. Public interface snapshot unchanged. No publish, no tag.
Contributor
|
APIError: Insufficient Balance |
Deploying openelement with
|
| Latest commit: |
2a48010
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://82f87c00.lessjs.pages.dev |
| Branch Preview URL: | https://v044-a10-12-correctness-swee.lessjs.pages.dev |
Type the dispatch seam as StartRequestHandlerOptions['dispatch'] instead of an unsafe cast (type-safety:check gate).
Contributor
|
APIError: Insufficient Balance |
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #1220 (umbrella #1155, Alpha.10): low-cost high-certainty defects confirmed at baseline — M4 (6 independent VOID_TAGS definitions, drifting: 2 included 'param', 4 didn't), M8 (start.ts async request callback without try/catch → unhandledRejection crash), M13 (hand-built file:// URL breaks on spaces/#), L1 (runtime vs server attribute escaping byte-divergent), M3 (latent triplicated when-operator), version-truth files partially unanchored.
Amendment authority
ADR-0151 — touches ADR-0122 §4 frozen path
packages/adapter-vite/src/cli/start.ts.Owner
VOID_TAGS canonical home:
element/src/internal/core/html-escape.ts(documented byte-mirrors only where an import edge is architecturally forbidden — sanitize.ts per ADR-0126, the two program.ts exchange artifacts per ADR-0148 — pinned by a byte-identity guard test). Escape contract: one canonical implementation shared by both serializers. No second semantics created anywhere.Evidence
…c<d>e'fvs…c<d>e'f); old file-URL concat failedModule not foundon a spaced/# path; start.ts had no containment seam (TS2305 on the new hostile tests); unhandledRejection crash demonstrated on the old pattern.deno task testexit 0; fmt/lint/typecheck/arch/freeze-semantics/docs:truth/package-surface/interface:snapshot all exit 0 (snapshot unchanged).Scope / non-goals
No general cleanup; runtime.ts edits are import-swap only (claim engine untouched); sanitize escapeAttr twin untouched (documented intentional).
Risk
'param' convergence makes validators/compiler fail closed on
<param>with children (spec-correct tightening); SSR attribute bytes change only where they were previously wrong. Rollback: revert.