Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While reproducing PubMedQA, I found two issues in
opencompass/configs/datasets/PubMedQA/PubMedQA_llmjudge_gen_f00302.py, specifically inGRADER_TEMPLATE.First, the template gives conflicting output instructions:
A: CORRECT,B: INCORRECTAorB"CORRECT,INCORRECT"The judge therefore receives two incompatible output formats.
Second, PubMedQA is a multiple-choice task whose original answer labels are
A/B/C. The same letters are visible in the question options, gold target, and candidate answer (for example,ANSWER: B), whileA/Bare also used as judge verdict labels. This label overlap can make the intended meaning of a generatedAorBambiguous.For example, when the gold answer is
Band the candidate prediction is alsoB, the correct judge verdict isA(CORRECT), butBis simultaneously the original task answer label. The same risk may exist in other multiple-choice benchmarks that reuse task-option labels as judge verdict labels; this PR is intentionally limited to the reproduced PubMedQA case.Modification
Xfor correct andYfor incorrect in the PubMedQA judge prompt.generic_llmjudge_postprocesswithtrue_tag='X'andfalse_tag='Y'.Validation
No changes are made to
GenericLLMEvaluatoror the generic parser.