Improve performance: load only completed jobs for the reset-jobs dialog - #262
Open
BmBaczkowski wants to merge 1 commit into
Open
Improve performance: load only completed jobs for the reset-jobs dialog#262BmBaczkowski wants to merge 1 commit into
BmBaczkowski wants to merge 1 commit into
Conversation
- add optional status_id filtering to the participant jobs endpoint - filter participant-job records by pivot status in the database query - request only status_id=3 jobs when opening the reset-jobs dialog - remove the redundant client-side filtering - preserve the existing endpoint behavior when no status_id is provided - return an empty result for filtered requests with no matching jobs Relates to #260
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the performance of the reset-jobs dialog by filtering participant jobs by status on the server.
Previously, opening the dialog requested all jobs for the participant and study. The client then discarded every job whose pivot status was not 3.
The request now includes status_id=3, and the existing participant-jobs endpoint applies the filter to the participant-job pivot query.
Closes #260