refactor!: remove dead rtree spatial index from areafilter - #41
Merged
Conversation
get_intersecting and get_knearest had no callers anywhere in the codebase, tests, or docs — they were viewport-culling helpers for the upstream BlueSky radar GUI, which MiniSky has removed. Drop them along with everything that existed only to feed them: the rtree Index and its libspatialindex-missing fallback shim, area_id/max_area_id, the areas_by_id/areas_by_name weak dicts, Shape.bbox, Shape.__del__, and _register/_unregister. AreaFilter now tracks shapes solely in the basic_shapes dict, which was already the registry every live code path used. Also drop the rtree dependency from pyproject.toml, refresh the lock, and add tracking-lifecycle tests (delete, redefine-replaces, LIST) that the removed registration path previously left uncovered. Closes #31
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
minisky | ade9322 | Aug 02 2026, 09:07 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #31,
get_intersectingandget_knearestwere viewport-culling helpers for the removed radar GUI with no callers anywhere in the codebase, so this removes them along with the rtree index, the fallback shim, and all the registration bookkeeping that existed only to feed them —AreaFilternow tracks shapes solely inbasic_shapes, which every live code path already used. Thertreedependency is dropped frompyproject.tomland the lock refreshed, and new tests cover the tracking lifecycle (delete, redefine-replaces, LIST) that the removed registration path previously left untested.Closes #31