refactor!: misc code quality updates - #39
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
minisky | 03d9f7d | Aug 02 2026, 08:20 AM |
slim down on the lints following open-aviation/tangram@d506079
we promise py310 anyway so we can use `match` nicely note that the REST API still uses *internally tagged enums* for compatibility
- server should be launched with `minisky.server` - allow controlling server host/port in config.toml
abc8747
force-pushed
the
pr-misc-updates
branch
from
August 2, 2026 06:14
15024cc to
07a42ed
Compare
abc8747
marked this pull request as ready for review
August 2, 2026 08:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Ruff lints, changes typing, and moves tests into individual plugins. Best reviewed commit-by-commit.
Breaking Changes:
Resultenum instead of the Go-likeok, resulttuple. Use Python 3.10 structural pattern matching to check if it isOk(), otherwise extract theErr.These will be worked on the future, not included in this PR:
static/andscenarios/inside the wheel?stack/commands.py’sdict[str, list[Any]]+ string argument DSL with typed command declarations andannotatedmetadata (replace the stack-command arguments DSL with typed Annotated schemas #37)float | np.ndarraytyping (should be done afterisqxis integrated, see replace manual conversion factors withisqxand annotate physical quantities with it #38)stop()can discard a still-running thread, while redis clients/pubsubs are never explicitly closedtracing-like sinks so it works across {tangram, websockets, REST API, stdout/stderr, log file...}